Donor reset

So with force open disabled, the donation goals widget disappeared once the goal was reached. The only way to make it reappear was to re-enable force open.

I did some further testing around the auto reset and i think i have nailed down the specific problem area.

To recap the intended outcome : Show goal progress, and donors via the "Donation Goals" and "Donation List" Blocks respectively. Upon reaching the intended Goal amount, hold the goal open, and retain the list of donors, until the goal reset date is reached. In short have a recurring goal, with a set reset date, and allow donors to see that the goal has been exceeded until the donation period resets.

Actual outcome: Goal and reset date are set as intended. With "Force Open" enabled, the "Donation Goals" progress bar will exceed the goal amount, but will not reset once the reset date is reached. The auto reset function can be seen to (partially?) work, as the "Donation List" block does clear the list of Donors on the intended reset date. Disabling Force Open has the expected behavior of removing the Donation Goal block once the amount is reached, the "Donation List" block stays present and populated until the reset date is reached, at which point it resets to blanks.

Expected behaviour: Both "Donation Goal" and "Donation List" blocks work in the same manner, that is, both remain present past the goal target (force open), but both reset to 0.00 and Blank once the auto reset date is reached.

Further testing notes: Moving the reset date back and forth will make the list of donors to reset, and then reappear, suggesting that logic similar to "Select donors from donations where donation-date => resetdate" is used to filter the block.

Possible cause: "Donation Goal" does not use the same logic to filter progress as the "Donation List" block. Looking at the code for the frontend components, i can see that "Donations List" donateDonations.php does contain a filter function:

/* Automatic reset? */
        if( \IPS\Settings::i()->dt_donation_reset )
        {
            $where[] = array( 'date>?', (int) \IPS\Settings::i()->dt_donation_reset );    
        }

donateGoals.php however does not.