Topic view hook

It hasn't done any change for me :-/

Edited November 17, 2017 by cybernck

11 minutes ago, cybernck said:

It hasn't done any change for me :-/

That's also with the "Show topic view hook?" collections setting enabled?

Yes,

22 hours ago, cybernck said:

Yes,

It might be a cache issue, I assume it's still the case after logging out and back in?

Nope, still doesn't work. I've seen some other forums without badges but I can't tell if they had it turned on or not in the first place.

Hmm, I've just noticed that the very few members that have edited their car after the update to IPS4 have a small "x car(s)" badge in Topic View! Therefore, it appears to we working but doesn't take into account records that haven't been added or edited since the migration. Hope this helps?

17 hours ago, cybernck said:

Hmm, I've just noticed that the very few members that have edited their car after the update to IPS4 have a small "x car(s)" badge in Topic View! Therefore, it appears to we working but doesn't take into account records that haven't been added or edited since the migration. Hope this helps?

Yep that sounds like the case. The item count wasn't rebuilt properly after the import. Just how many vehicles do you have present? If not too many, running this code should do a full rebuild for you.

		foreach( \IPS\Db::i()->select( '*', 'collections_items', null, 'id ASC' ) as $row )
		{
            $item = \IPS\collections\Item::constructFromData( $row );		  
            /* Rebuild item count */
            $item->rebuildItemCount();		
		}

So for example, add that into the "manage" function of the applications/collections/modules/admin/collections/settings.php file and then open the collections settings page in the admin. That will perform the rebuild for all your vehicles and get all your members item counts up to date.

If you do have quite a few vehicles, let me know and can modify to run a subset at a time.

How many is too many? :) I've got 837 at the moment.

I assume I only need to run that code only once and then remove it?

It depends on the database and your server but I'd probably try and limit to maybe 100 at a time. So try this query and adjust.

foreach( \IPS\Db::i()->select( '*', 'collections_items', null, 'id ASC', array( 0, 100 ) ) as $row )
		{
            $item = \IPS\collections\Item::constructFromData( $row );		  
            /* Rebuild item count */
            $item->rebuildItemCount();		
		}

And then adjust the last limit portion to array( 100, 100 ) and then array( 200, 100 ) and so on. Until you get to array( 800, 100 ) to run the last bit. I hope that makes sense.

21 hours ago, cybernck said:

I assume I only need to run that code only once and then remove it?

Yes that's correct. The system will then keep everything up to date itself.

OK, I will do it soon and let you know the outcome.

P.S. Just to check if there would perhaps be a mysql command that could be run in ssh or phpmyadmin instead?

I haven't yet run this patch as I've been installing SSL certificate and rebuilding whatever IPS system wanted me to rebuild to support SSL but I've now noticed that all of a sudden there's an error with Vehicle naming - the titles gained paragraph tags?
https://www.205gtidrivers.com/garage/

However, a car that has been added today doesn't have them, so it seems that it somehow happened retroactively for the existing items.

Any idea why?

I've now run the script and it has fixed the topic view hook, thanks!

It's just that it's always in plural, e.g. "1 Cars" ;).

Any thoughts on the <p> issue? Should I just clean it up in the db itself?

I edited the <p> tags out in the DB but soon enough they've returned. What could be causing this?!

I'm sorry I missed your replies there. After you remove it from the database, does anything in particular re=add them? For example do you need to edit the vehicle again and it comes up?

The only thing I've done in the meantime was to disable https image recaching, which required some posts to be rebuilt...

I've now once again removed the tags, so we'll see what happens now and what triggers it.

Ah yes, so it's RebuildImageProxy.php causing it. Here's what IPS said about it:

This is because the Image Proxy Rebuild task is application agnostic, and will perform adjustments on anything an application defines as a content item. For that application, it defines the data in that table as content. If this is undesirable, then I would recommend contacting the author of that application.

7 hours ago, cybernck said:

I've now once again removed the tags, so we'll see what happens now and what triggers it.

It shouldn't if the posts have all been rebuilt now. But this is a problem due to this bit of code in the applications/collections/sources/Item/Item.php file. The image rebuild is rebuild all content values and sees the item name as something to rebuild.

'content'        => 'item_name',

I set it as a content item for some reason but will test removing it in the next version.

I need to do it every so often when I'm replacing broken Photobucket pics.

So... there's no easy fix?

Sorry I should of been more clear. The above edit will patch this temporarily but I just need to test it more for the official next release.

Hmm, which patch? The original patch has sorted out the Topic View Hook issue but we're talking about something else here now.

But there's a much bigger problem now, check my latest bug report :(.

https://www.devfuse.com/forums/bugs/collections/resetting-all-fields-on-edit-r45/

 

On 12/11/2017 at 8:58 AM, cybernck said:

Hmm, which patch? The original patch has sorted out the Topic View Hook issue but we're talking about something else here now.

This patch here - https://www.devfuse.com/forums/bugs/collections/topic-view-hook-r33/?do=findComment&comment=106

Changed Status to Fixed